Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 8429011: Fix a ChromeFrame crash which occurs in the background worker thread while dereferencing a NULL a... (Closed)

Created:
9 years, 1 month ago by ananta
Modified:
9 years, 1 month ago
Reviewers:
robertshield
CC:
chromium-reviews, amit, robertshield
Visibility:
Public.

Description

Fix a ChromeFrame crash which occurs in the background worker thread while dereferencing a NULL automation client. This crash occurs when the active document is in the process of shutting down while there are active background requests still pending. Fix is to ensure that the background thread has been stopped before returning from the UrlmonUrlRequestManager::StopAll function which gets called during CF shutdown. Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393 BUG=102393 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome_frame/urlmon_url_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 1 month ago (2011-10-31 18:15:41 UTC) #1
robertshield
9 years, 1 month ago (2011-10-31 18:38:14 UTC) #2
lg, is there any way to write a quick test for this?

Powered by Google App Engine
This is Rietveld 408576698