Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 8429009: Enable tracking of objects by default (Closed)

Created:
9 years, 1 month ago by jar (doing other things)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, sadrul, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Enable tracking of objects by default This is a reland of accumulated patches including CLs 8414036, 8425010, 8425013, 8424013. It fully enables tracking of objects, as seen in about:tracking in teh release build. The problem this had in its initaial landing centered on Mac instability in base_unittest. We were encountering crash on exit of the tests, with a stack dump involving pthreads. r=rtenneti BUG=101856 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108026

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+894 lines, -411 lines) Patch
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M base/location.h View 1 chunk +0 lines, -6 lines 0 comments Download
M base/message_loop.h View 4 chunks +2 lines, -14 lines 0 comments Download
base/message_loop.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M base/threading/thread.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/threading/worker_pool_posix.h View 1 chunk +2 lines, -4 lines 0 comments Download
M base/threading/worker_pool_posix.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M base/threading/worker_pool_win.cc View 2 chunks +9 lines, -15 lines 0 comments Download
M base/tracked_objects.h View 1 2 3 21 chunks +211 lines, -76 lines 0 comments Download
M base/tracked_objects.cc View 1 2 3 16 chunks +239 lines, -143 lines 0 comments Download
base/tracked_objects_unittest.cc View 13 chunks +299 lines, -101 lines 0 comments Download
A base/tracking_info.h View 1 2 3 4 5 1 chunk +41 lines, -0 lines 0 comments Download
A base/tracking_info.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 5 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 3 chunks +16 lines, -9 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 2 3 4 5 6 7 8 9 1 chunk +17 lines, -0 lines 0 comments Download
M tools/valgrind/tsan/suppressions_mac.txt View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jar (doing other things)
John, Please review/approve the content change. Raman will work on the broader review me (he ...
9 years, 1 month ago (2011-10-31 20:51:17 UTC) #1
jam
content lgtm
9 years, 1 month ago (2011-10-31 20:53:27 UTC) #2
ramant (doing other things)
LGTM. Changes seem to be same as what was reviewed before except for disabling it ...
9 years, 1 month ago (2011-10-31 21:22:33 UTC) #3
ramant (doing other things)
9 years, 1 month ago (2011-10-31 22:32:04 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698