Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 8429005: Tweak the WebDragDestDelegate to be useful for more than GTK. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, creis+watch_chromium.org, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : TOOLKIT_USES_GTK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -75 lines) Patch
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.h View 1 chunk +11 lines, -10 lines 0 comments Download
A + content/browser/tab_contents/web_drag_dest_delegate.h View 1 3 chunks +14 lines, -10 lines 0 comments Download
D content/browser/tab_contents/web_drag_dest_delegate_gtk.h View 1 chunk +0 lines, -49 lines 0 comments Download
M content/browser/tab_contents/web_drag_dest_gtk.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/tab_contents/web_drag_dest_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
9 years, 1 month ago (2011-10-31 16:33:06 UTC) #1
Elliot Glaysher
lgtm I assume you plan on adding a #elsif OS_MAC section for mac specific clipboard ...
9 years, 1 month ago (2011-10-31 17:13:18 UTC) #2
Avi (use Gerrit)
I have two followup patches ready to go but no, turns out that's not necessary.
9 years, 1 month ago (2011-10-31 17:39:43 UTC) #3
Avi (use Gerrit)
Can I ask some advice here? I'm using "#if defined(TOOLKIT_GTK)", but that fails on the ...
9 years, 1 month ago (2011-10-31 19:26:19 UTC) #4
Elliot Glaysher
On 2011/10/31 19:26:19, Avi wrote: > Do you have any suggestions for "this is gtk, ...
9 years, 1 month ago (2011-10-31 19:29:57 UTC) #5
Avi (use Gerrit)
ptal. trybots for linux and linux_views running now.
9 years, 1 month ago (2011-10-31 19:33:50 UTC) #6
Elliot Glaysher
9 years, 1 month ago (2011-10-31 19:38:17 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698