Update JRE version metadata.

Update JRE version metadata.

BUG=102461
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108143

[Chris Evans, 2011-11-01 03:07:55]

Metadata-only change. Request quick review if feasible :)

[cevans, 2011-11-01 04:15:06]

Note to reviewer: I'll submit this also with a Mac change to remove maximum
/ minimum versions. I won't actually change any of the versions required as
we haven't decoded the Lion story yet, nor the support story for older
MacOSX. Let me know of any concerns.

On Mon, Oct 31, 2011 at 8:07 PM, <cevans@chromium.org> wrote:

> Reviewers: Bernhard Bauer,
>
> Message:
> Metadata-only change. Request quick review if feasible :)
>
> Description:
> Update JRE version metadata.
>
> BUG=102461
>
> Please review this at
http://codereview.chromium.**org/8428011/<http://codereview.chromium.org/8428...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     webkit/plugins/npapi/plugin_**list.cc
>
>
> Index: webkit/plugins/npapi/plugin_**list.cc
> ==============================**==============================**=======
> --- webkit/plugins/npapi/plugin_**list.cc (revision 107012)
> +++ webkit/plugins/npapi/plugin_**list.cc (working copy)
> @@ -93,7 +93,8 @@
>     { "", "", "7.6.9", true }
>  };
>  static const VersionRangeDefinition kJavaVersionRange[] = {
> -    { "0", "7", "6.0.260", true }  // "260" is not a typo.
> +    { "0", "7", "6.0.290", true },  // "290" is not a typo.
> +    { "7", "", "10.1", true }  // JDK7u1 identifies itself as 10.1
>  };
>  // This is up to date with
>  //
http://www.adobe.com/support/**security/bulletins/apsb11-08.**html<http://www...
> @@ -146,12 +147,14 @@
>
>  #else  // Most importantly, covers desktop Linux.
>  static const VersionRangeDefinition kJavaVersionRange[] = {
> -    { "0", "1.7", "1.6.0.26", true }
> +    { "0", "1.7", "1.6.0.29", true },
> +    { "1.7", "", "1.7.0.1", true }
>  };
>
>  static const VersionRangeDefinition kRedhatIcedTeaVersionRange[] = {
> -    { "0", "1.9", "1.8.8", true },
> -    { "1.9", "1.10", "1.9.8", true },
> +    { "0", "1.9", "1.8.10", true },
> +    { "1.9", "1.10", "1.9.10", true },
> +    { "1.10", "", "1.10.4", true }
>  };
>
>  static const PluginGroupDefinition kGroupDefinitions[] = {
>
>
>

[Bernhard Bauer, 2011-11-01 10:35:36]

On 2011/11/01 04:15:06, cevans wrote:
> Note to reviewer: I'll submit this also with a Mac change to remove maximum
> / minimum versions. I won't actually change any of the versions required as
> we haven't decoded the Lion story yet, nor the support story for older
> MacOSX. Let me know of any concerns.

This change LGTM, but I don't understand that note ;-) What are you going to
change in addition?

> On Mon, Oct 31, 2011 at 8:07 PM, <mailto:cevans@chromium.org> wrote:
> 
> > Reviewers: Bernhard Bauer,
> >
> > Message:
> > Metadata-only change. Request quick review if feasible :)
> >
> > Description:
> > Update JRE version metadata.
> >
> > BUG=102461
> >
> > Please review this at
>
http://codereview.chromium.**org/8428011/%3Chttp://codereview.chromium.org/84...>
> >
> > SVN Base:
>
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
> >
> > Affected files:
> >  M     webkit/plugins/npapi/plugin_**list.cc
> >
> >
> > Index: webkit/plugins/npapi/plugin_**list.cc
> > ==============================**==============================**=======
> > --- webkit/plugins/npapi/plugin_**list.cc (revision 107012)
> > +++ webkit/plugins/npapi/plugin_**list.cc (working copy)
> > @@ -93,7 +93,8 @@
> >     { "", "", "7.6.9", true }
> >  };
> >  static const VersionRangeDefinition kJavaVersionRange[] = {
> > -    { "0", "7", "6.0.260", true }  // "260" is not a typo.
> > +    { "0", "7", "6.0.290", true },  // "290" is not a typo.
> > +    { "7", "", "10.1", true }  // JDK7u1 identifies itself as 10.1
> >  };
> >  // This is up to date with
> >  //
>
http://www.adobe.com/support/**security/bulletins/apsb11-08.**html%3Chttp://w...>
> > @@ -146,12 +147,14 @@
> >
> >  #else  // Most importantly, covers desktop Linux.
> >  static const VersionRangeDefinition kJavaVersionRange[] = {
> > -    { "0", "1.7", "1.6.0.26", true }
> > +    { "0", "1.7", "1.6.0.29", true },
> > +    { "1.7", "", "1.7.0.1", true }
> >  };
> >
> >  static const VersionRangeDefinition kRedhatIcedTeaVersionRange[] = {
> > -    { "0", "1.9", "1.8.8", true },
> > -    { "1.9", "1.10", "1.9.8", true },
> > +    { "0", "1.9", "1.8.10", true },
> > +    { "1.9", "1.10", "1.9.10", true },
> > +    { "1.10", "", "1.10.4", true }
> >  };
> >
> >  static const PluginGroupDefinition kGroupDefinitions[] = {
> >
> >
> >

[cevans, 2011-11-01 17:59:07]

On Tue, Nov 1, 2011 at 3:35 AM, <bauerb@chromium.org> wrote:

> On 2011/11/01 04:15:06, cevans wrote:
>
>> Note to reviewer: I'll submit this also with a Mac change to remove
>> maximum
>> / minimum versions. I won't actually change any of the versions required
>> as
>> we haven't decoded the Lion story yet, nor the support story for older
>> MacOSX. Let me know of any concerns.
>>
>
> This change LGTM, but I don't understand that note ;-) What are you going
> to
> change in addition?


Sorry. We did this properly in the end, i.e. got a Lion machine and grabbed
its Java version:

    { "14.0", "", "14.0.3", true }  // Lion

The thing I was rambling about was making sure that the highest version
range in the array has no upper limit. This ensures that any future major
version bumps will still get infobar'ed.


>
>  On Mon, Oct 31, 2011 at 8:07 PM, <mailto:cevans@chromium.org> wrote:
>>
>
>  > Reviewers: Bernhard Bauer,
>> >
>> > Message:
>> > Metadata-only change. Request quick review if feasible :)
>> >
>> > Description:
>> > Update JRE version metadata.
>> >
>> > BUG=102461
>> >
>> > Please review this at
>>
>
> http://codereview.chromium.****org/8428011/%3Chttp://coderevi**
> ew.chromium.org/8428011/ <http://codereview.chromium.org/8428011/>>
>
>> >
>> > SVN Base:
>>
>
>
svn://svn.chromium.org/chrome/****trunk/src/<http://svn.chromium.org/chrome/**trunk/src/>
>
<http://svn.**chromium.org/chrome/trunk/src/<http://svn.chromium.org/chrome/tr...
> **>
>
>> >
>> > Affected files:
>> >  M     webkit/plugins/npapi/plugin_****list.cc
>> >
>> >
>> > Index: webkit/plugins/npapi/plugin_****list.cc
>> > ==============================****============================**
>> ==**=======
>> > --- webkit/plugins/npapi/plugin_****list.cc (revision 107012)
>> > +++ webkit/plugins/npapi/plugin_****list.cc (working copy)
>>
>> > @@ -93,7 +93,8 @@
>> >     { "", "", "7.6.9", true }
>> >  };
>> >  static const VersionRangeDefinition kJavaVersionRange[] = {
>> > -    { "0", "7", "6.0.260", true }  // "260" is not a typo.
>> > +    { "0", "7", "6.0.290", true },  // "290" is not a typo.
>> > +    { "7", "", "10.1", true }  // JDK7u1 identifies itself as 10.1
>> >  };
>> >  // This is up to date with
>> >  //
>>
>
> http://www.adobe.com/support/****security/bulletins/apsb11-08.**
> **html%3Chttp://www.adobe.com/**support/security/bulletins/**
>
apsb11-08.html<http://www.adobe.com/support/**security/bulletins/apsb11-08.**html%3Chttp://www.adobe.com/support/security/bulletins/apsb11-08.html>
> >
>
>  > @@ -146,12 +147,14 @@
>> >
>> >  #else  // Most importantly, covers desktop Linux.
>> >  static const VersionRangeDefinition kJavaVersionRange[] = {
>> > -    { "0", "1.7", "1.6.0.26", true }
>> > +    { "0", "1.7", "1.6.0.29", true },
>> > +    { "1.7", "", "1.7.0.1", true }
>> >  };
>> >
>> >  static const VersionRangeDefinition kRedhatIcedTeaVersionRange[] = {
>> > -    { "0", "1.9", "1.8.8", true },
>> > -    { "1.9", "1.10", "1.9.8", true },
>> > +    { "0", "1.9", "1.8.10", true },
>> > +    { "1.9", "1.10", "1.9.10", true },
>> > +    { "1.10", "", "1.10.4", true }
>> >  };
>> >
>> >  static const PluginGroupDefinition kGroupDefinitions[] = {
>> >
>> >
>> >
>>
>
>
>
>
http://codereview.chromium.**org/8428011/<http://codereview.chromium.org/8428...
>