Issue 8428010: Cleanup: Remove ViewProp from aura build

Issue 8428010: Cleanup: Remove ViewProp from aura build (Closed)

Created:
9 years, 1 month ago by oshima

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove ViewProp from aura build Enforce that ViewProp is included only on win, non-aura build. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108128

Patch Set 3 : addressed comments #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -31 lines)			Patch
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2	3 chunks	+4 lines, -7 lines	0 comments	Download
M	ui/aura/window.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	ui/aura/window.cc	View	1	3 chunks	+5 lines, -7 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	1	2 chunks	+0 lines, -8 lines	0 comments	Download
M	ui/aura_shell/default_container_layout_manager.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura_shell/default_container_layout_manager_unittest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura_shell/shell.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/view_prop.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/ui_unittests.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/8428010/diff/3011/chrome/browser/ui/views/frame/browser_view.cc File chrome/browser/ui/views/frame/browser_view.cc (right): http://codereview.chromium.org/8428010/diff/3011/chrome/browser/ui/views/frame/browser_view.cc#newcode380 chrome/browser/ui/views/frame/browser_view.cc:380: views::Widget* widget = views::Widget::GetWidgetForNativeWindow(window); It's entirely possible widget is ...

9 years, 1 month ago (2011-11-01 14:54:40 UTC) #2

oshima

9 years, 1 month ago (2011-11-01 15:36:56 UTC) #3

LGTM

Expand Messages | Collapse Messages