Print Preview: Making margin selection sticky (part 1/2).

printing/print_job_constants.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PRINTING_PRINT_JOB_CONSTANTS_H_
 #define PRINTING_PRINT_JOB_CONSTANTS_H_
 
 #include "printing/printing_export.h"
 
 namespace printing {
@@ skipping 100 matching lines @@
   PRINTOUTMODE_NORMAL_GRAY,  // Used in foomatic ppds.
   PROCESSCOLORMODEL_CMYK,  // Used in canon printer ppds.
   PROCESSCOLORMODEL_GREYSCALE,  // Used in canon printer ppds.
   PROCESSCOLORMODEL_RGB,  // Used in canon printer ppds
 };
 
 // What kind of margins to use.
 enum MarginType {
   DEFAULT_MARGINS,  // Default varies depending on headers being enabled or not
   NO_MARGINS,
+  PRINTABLE_AREA_MARGINS,

[kmadhusu, 2011/11/01 17:17:57]

Can you rename this as MINIMUM_MARGINS?

[dpapad, 2011/11/01 17:29:14]

I think that the current name is more descriptive from the suggested ine. We
display "Minimum" to the user for simplicity but that does not need to affect
internal naming. Maybe vandebo has a stronger opinion on whether to rename or
not.

   CUSTOM_MARGINS,
-  PRINTABLE_AREA_MARGINS,
 };
 
 }  // namespace printing
 
 #endif  // PRINTING_PRINT_JOB_CONSTANTS_H_