Print Preview: Making margin selection sticky (part 1/2).

chrome/browser/resources/print_preview/margin_settings.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Creates a Margins object that holds four margin values. The units in which
    * the values are expressed can be any numeric value.
@@ skipping 133 matching lines @@
     // @type {EventTracker} Used to keep track of certain event listeners.
     this.eventTracker_ = new EventTracker();
 
     this.addEventListeners_();
   }
 
   // Number of points per inch.
   MarginSettings.POINTS_PER_INCH = 72;
   // Minimum allowed distance in points between top-bottom, left-right margins.
   MarginSettings.MINIMUM_MARGINS_DISTANCE = 36;
-  // Margin list values.
+  // Margin list values. Matches enum MarginType in
+  // printing/print_job_constants.h.
   MarginSettings.MARGINS_VALUE_DEFAULT = 0;
   MarginSettings.MARGINS_VALUE_NO_MARGINS = 1;
-  MarginSettings.MARGINS_VALUE_CUSTOM = 2;
-  MarginSettings.MARGINS_VALUE_MINIMUM = 3;
+  MarginSettings.MARGINS_VALUE_MINIMUM = 2;
+  MarginSettings.MARGINS_VALUE_CUSTOM = 3;
   // Default Margins option index.
-  MarginSettings.DEFAULT_MARGINS_OPTION_INDEX = 0;
+  MarginSettings.OPTION_INDEX_DEFAULT = 0;
   // Group name corresponding to the top margin.
   MarginSettings.TOP_GROUP = 'top';
   //  Group name corresponding to the left margin.
   MarginSettings.LEFT_GROUP = 'left';
   // Group name corresponding to the right margin.
   MarginSettings.RIGHT_GROUP = 'right';
   // Group name corresponding to the bottom margin.
   MarginSettings.BOTTOM_GROUP = 'bottom';
 
   /**
@@ skipping 32 matching lines @@
 
     /**
      * @return {number} The value of the selected margin option.
      */
     get selectedMarginsValue() {
       var val = this.marginList_.options[this.marginList_.selectedIndex].value;
       return parseInt(val, 10);
     },
 
     /**
+     * Sets the current margin selection to |lastUsedMarginsType|.
+     * @param {number} lastUsedMarginsType An integer value identifying a margin
+     *     type according to MarginType enum in printing/print_job_constants.h.
+     */
+    setLastUsedMarginsType: function(lastUsedMarginsType) {
+      this.marginList_.selectedIndex =
+          this.marginValueTypeToIndex(lastUsedMarginsType);
+    },
+
+    /**
      * @return {number} The total width of the plugin in points.
      */
     get totalWidthInPoints() {
       var pageInformation = previewArea.pageLocationNormalized;
       return this.pageWidth_ / pageInformation.width;
     },
 
     /**
      * @return {number} The total height of the plugin in points.
      */
     get totalHeightInPoints() {
       var pageInformation = previewArea.pageLocationNormalized;
       return this.pageHeight_ / pageInformation.height;
     },
 
     /**
+     * Maps margin type values to indices within |this.marginList_|.
+     * @param {number} marginTypeValue An integer value identifying a margin
+     *     type according to MarginType enum in printing/print_job_constants.h.
+     * @return {number} The index within |this.marginList_| that corrsponds to
+     *     |marginTypeValue|.
+     */
+    marginValueTypeToIndex: function(marginTypeValue) {

[kmadhusu, 2011/11/01 22:12:25]

marginValueTypeToIndex  => getMarginOptionIndexByValue()?? 

[kmadhusu, 2011/11/01 22:12:25]

private function?

[dpapad, 2011/11/01 22:38:34]

Done.

[dpapad, 2011/11/01 22:38:34]

Done.

+      var options = this.marginList_.options;
+      for (var i = 0; i < options.length; i++) {
+        if (options[i].getAttribute('value') == marginTypeValue)
+          return i;
+      }
+      return 0;
+    },
+
+    /**
      * @return {boolean} True if default margins are selected.
      */
     isDefaultMarginsSelected: function() {
       return this.selectedMarginsValue == MarginSettings.MARGINS_VALUE_DEFAULT;
     },
 
     /**
      * @return {boolean} True if no margins are selected.
      */
     isNoMarginsSelected: function() {
@@ skipping 350 matching lines @@
     },
 
     /**
      * If custom margins is the currently selected option then change to the
      * default margins option.
      * @private
      */
     resetMarginsIfNeeded: function() {
       if (this.isCustomMarginsSelected()) {
         this.marginList_.options[
-            MarginSettings.DEFAULT_MARGINS_OPTION_INDEX].selected = true;
+            MarginSettings.OPTION_INDEX_DEFAULT].selected = true;
         this.removeCustomMarginEventListeners_();
         this.forceDisplayingMarginLines_ = true;
         this.lastSelectedOption_ = MarginSettings.MARGINS_VALUE_DEFAULT;
       }
     },
 
     /**
      * Executes when a |customEvents.PDF_LOADED| event occurs.
      * @private
      */
     onPDFLoaded_: function() {
       if (!previewModifiable)
         fadeOutOption(this.marginsOption_);
     }
   };
 
   return {
     MarginSettings: MarginSettings,
     PageLayout: PageLayout,
     setNumberFormatAndMeasurementSystem:
         MarginSettings.setNumberFormatAndMeasurementSystem,
   };
 });