Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 8428004: MIPS: Cleanup: use JumpIf[Not]Smi() whenever we can (Closed)

Created:
9 years, 1 month ago by kisg
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Cleanup: use JumpIf[Not]Smi() whenever we can Port r8322 (7b8b4a951f). BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9885

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed typo, rebased to r9884 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -40 lines) Patch
M src/mips/builtins-mips.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips/ic-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 4 chunks +4 lines, -8 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 6 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kisg
Please land the following commits together to avoid build errors: http://codereview.chromium.org/8384021/ http://codereview.chromium.org/8428004/ http://codereview.chromium.org/8387044/ http://codereview.chromium.org/8432010/ Thank ...
9 years, 1 month ago (2011-10-31 20:26:13 UTC) #1
Jakob Kummerow
Almost LGTM :-) http://codereview.chromium.org/8428004/diff/1/src/mips/macro-assembler-mips.cc File src/mips/macro-assembler-mips.cc (right): http://codereview.chromium.org/8428004/diff/1/src/mips/macro-assembler-mips.cc#newcode4482 src/mips/macro-assembler-mips.cc:4482: JumpIfSmi(at, on_not_both_smi); Shouldn't this be JumpIfNotSmi?
9 years, 1 month ago (2011-11-04 09:10:52 UTC) #2
kisg
On 2011/11/04 09:10:52, Jakob wrote: > http://codereview.chromium.org/8428004/diff/1/src/mips/macro-assembler-mips.cc#newcode4482 > src/mips/macro-assembler-mips.cc:4482: JumpIfSmi(at, on_not_both_smi); > Shouldn't this be ...
9 years, 1 month ago (2011-11-04 17:10:01 UTC) #3
Jakob Kummerow
9 years, 1 month ago (2011-11-07 08:23:20 UTC) #4
OK, I'll land.

Powered by Google App Engine
This is Rietveld 408576698