net/base/x509_certificate.cc - Issue 8427024: A quick fix for Mac GCC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_certificate.cc

Issue 8427024: A quick fix for Mac GCC. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/x509_certificate.cc

===================================================================

--- net/base/x509_certificate.cc (revision 108043)

+++ net/base/x509_certificate.cc (working copy)

@@ -710,7 +710,8 @@

{0x3e,0x75,0xce,0xd4,0x6b,0x69,0x30,0x21,0x21,0x88,0x30,0xae,0x86,0xa8,0x2a,0x71},

};

- if (!serial_number_.empty() && serial_number_[0] >= 0x80) {

+ if (!serial_number_.empty() &&

+ static_cast<unsigned char>(serial_number_[0]) >= 0x80) {

// This is a negative serial number, which isn't technically allowed but

// which probably happens. In order to avoid confusing a negative serial

// number with a positive one once the leading zeros have been removed, we

« net/base/crl_set.cc ('K') | « net/base/crl_set.cc ('k') | no next file » | no next file with comments »