A quick fix for Mac GCC.

A quick fix for Mac GCC.
This change just uses bit testing so Mac GCC does not complain "comparison is always false due to limited range of data type".

BUG=none
TEST=fix build on the "Webkit Mac (valgrind)" bot

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108091

[Hironori Bono, 2011-11-01 02:22:02]

Greetings,

This is the build log
<http://build.chromium.org/p/chromium.memory.fyi/builders/Webkit%20Mac%20%28va...>
of the bot.

Regards,

Hironori Bono

[wtc, 2011-11-01 04:02:51]

LGTM.

http://codereview.chromium.org/8427024/diff/1/net/base/crl_set.cc
File net/base/crl_set.cc (right):

http://codereview.chromium.org/8427024/diff/1/net/base/crl_set.cc#newcode413
net/base/crl_set.cc:413: if (!serial.empty() && static_cast<unsigned
char>(serial[0]) >= 0x80) {

It may be better to use bit testing:
  (serial[0] & 0x80) != 0

[Hironori Bono, 2011-11-01 07:57:52]

http://codereview.chromium.org/8427024/diff/1/net/base/crl_set.cc
File net/base/crl_set.cc (right):

http://codereview.chromium.org/8427024/diff/1/net/base/crl_set.cc#newcode413
net/base/crl_set.cc:413: if (!serial.empty() && static_cast<unsigned
char>(serial[0]) >= 0x80) {
On 2011/11/01 04:02:51, wtc wrote:
> 
> It may be better to use bit testing:
>   (serial[0] & 0x80) != 0

Done. Thanks for your suggestion. It also fixes the bot.

[commit-bot: I haz the power, 2011-11-01 09:23:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hbono@chromium.org/8427024/3001

[commit-bot: I haz the power, 2011-11-01 10:33:20]

Change committed as 108091