Full screen info bubble after |Accept| should exit with link click

Full screen info bubble after |Accept| should exit with link click

BUG=102032
TEST=Enter Full screen, tab full screen, and mouse lock; verify that displayed exit text is a link and not plain text. Manual test in ppapi/examples/mouse_lock


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109935

[scheib, 2011-11-08 17:06:35]

UI for full screen and mouse lock exit modified to have a clickable link on
windows and linux. (Mac is already OK.)

Peter, can you take a look at _views?
Elliot, can you take a look at _gtk?

[Elliot Glaysher, 2011-11-08 17:57:26]

gtk lgtm

[scheib, 2011-11-09 17:57:27]

Peter, views?

[Peter Kasting, 2011-11-09 23:32:52]

LGTM

http://codereview.chromium.org/8427022/diff/5001/chrome/browser/ui/views/full...
File chrome/browser/ui/views/fullscreen_exit_bubble_views.cc (right):

http://codereview.chromium.org/8427022/diff/5001/chrome/browser/ui/views/full...
chrome/browser/ui/views/fullscreen_exit_bubble_views.cc:160: if
(fullscreen_bubble::ShowButtonsForType(bubble_type)) {
Nit: This whole block can be shortened, assuming the "bubble_->GetXXX()" calls
won't checkfail or similar:

  link_.SetText((bubble_type == FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION) ?
      browser_fullscreen_exit_text_ : bubble_->GetInstructionText());
  deny_button_->SetText(bubble_->GetCurrentDenyButtonText());
  deny_button_->ClearMaxTextSize();
  bool show_buttons = fullscreen_bubble::ShowButtonsForType(bubble_type);
  link_.SetVisible(show_buttons);
  accept_button_->SetVisible(show_buttons);
  deny_button_->SetVisible(show_buttons);

[commit-bot: I haz the power, 2011-11-14 17:47:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/8427022/5001

[scheib, 2011-11-14 17:51:34]

FYI I tried Peter's simplification, but it is guarded against in other
areas of code and was failing on some platforms. I'm landing the working
version as it's only a few more lines and perhaps easier to read the logic.

On Mon, Nov 14, 2011 at 9:47 AM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
> https://chromium-status.**appspot.com/cq/scheib@**
>
chromium.org/8427022/5001<https://chromium-status.appspot.com/cq/scheib@chromium.org/8427022/5001>
>
>
>
http://codereview.chromium.**org/8427022/<http://codereview.chromium.org/8427...
>

[commit-bot: I haz the power, 2011-11-14 19:36:25]

Change committed as 109935