Issue 8427020: Don't send a session-terminate in disconnect() if WCS not initialised.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8427020: Don't send a session-terminate in disconnect() if WCS not initialised. (Closed)

Created:
9 years, 1 month ago by Wez

Modified:
9 years, 1 month ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't send a session-terminate in disconnect() if WCS not initialised. sendIq_() requires that WCS is initialized when it is called, otherwise it will switch the session into the "failed" state. (The state change causes a disconnect() call, which triggers a sendIq_() and the tab locks up.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108061

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
	M	remoting/webapp/me2mom/client_session.js	View		1 chunk	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/8427020/1

9 years, 1 month ago (2011-11-01 01:12:54 UTC) #3

Change committed as 108061

Expand Messages | Collapse Messages