webkit/tools/test_shell/simple_resource_loader_bridge.cc - Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/tools/test_shell/simple_resource_loader_bridge.cc

Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest version as trybot-ted Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/tools/test_shell/simple_resource_loader_bridge.cc

diff --git a/webkit/tools/test_shell/simple_resource_loader_bridge.cc b/webkit/tools/test_shell/simple_resource_loader_bridge.cc

index 0b355ac0b12aa3d106c2d30f9a31d5d21c77da25..a3e0f64aa7eec11086e9e4dffbe3332760b42a02 100644

--- a/webkit/tools/test_shell/simple_resource_loader_bridge.cc

+++ b/webkit/tools/test_shell/simple_resource_loader_bridge.cc

@@ -123,8 +123,6 @@ class IOThread : public base::Thread {

}

~IOThread() {

- // We cannot rely on our base class to stop the thread since we want our

- // CleanUp function to run.

Stop();

}

« no previous file with comments | « webkit/appcache/appcache_update_job_unittest.cc ('k') | no next file » | no next file with comments »