chrome_frame/utils.h - Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/utils.h

Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest version as trybot-ted Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_frame/utils.h

diff --git a/chrome_frame/utils.h b/chrome_frame/utils.h

index 95feac6637c76e77ef3404106d87c420092b432c..c76b2a483184dcd42ce8a4bc49544325d59c6e82 100644

--- a/chrome_frame/utils.h

+++ b/chrome_frame/utils.h

@@ -387,6 +387,9 @@ STDMETHODIMP QueryInterfaceIfDelegateSupports(void* obj, REFIID iid,

class STAThread : public base::Thread {

public:

explicit STAThread(const char *name) : Thread(name) {}

+ ~STAThread() {

+ Stop();

+ }

bool Start() {

return StartWithOptions(Options(MessageLoop::TYPE_UI, 0));

}

« no previous file with comments | « chrome_frame/urlmon_url_request.cc ('k') | content/browser/browser_thread_impl.cc » ('j') | no next file with comments »