base/memory/weak_ptr_unittest.cc - Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/weak_ptr_unittest.cc

Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest version as trybot-ted Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/memory/weak_ptr_unittest.cc

diff --git a/base/memory/weak_ptr_unittest.cc b/base/memory/weak_ptr_unittest.cc

index c244ec05ab516fd7db1ecfe42ea4cf5b780121cb..f9f8b3e916a27bcbfaf7a72a28ae311b9ac08313 100644

--- a/base/memory/weak_ptr_unittest.cc

+++ b/base/memory/weak_ptr_unittest.cc

@@ -47,6 +47,10 @@ class BackgroundThread : public Thread {

: Thread("owner_thread") {

}

+ ~BackgroundThread() {

+ Stop();

+ }

void CreateConsumerFromProducer(Consumer** consumer, Producer* producer) {

WaitableEvent completion(true, false);

message_loop()->PostTask(

« no previous file with comments | « no previous file | base/threading/thread.h » ('j') | no next file with comments »