Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: chrome_frame/urlmon_url_request.cc

Issue 8427007: Thread::Stop() must be called before any subclass's destructor completes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Latest version as trybot-ted Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome_frame/test/urlmon_moniker_integration_test.cc ('k') | chrome_frame/utils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome_frame/urlmon_url_request.h" 5 #include "chrome_frame/urlmon_url_request.h"
6 6
7 #include <urlmon.h> 7 #include <urlmon.h>
8 #include <wininet.h> 8 #include <wininet.h>
9 9
10 #include "base/callback_old.h" 10 #include "base/callback_old.h"
(...skipping 1395 matching lines...) Expand 10 before | Expand all | Expand 10 after
1406 PostMessage(notification_window_, WM_FIRE_PRIVACY_CHANGE_NOTIFICATION, 1, 1406 PostMessage(notification_window_, WM_FIRE_PRIVACY_CHANGE_NOTIFICATION, 1,
1407 0); 1407 0);
1408 } 1408 }
1409 } 1409 }
1410 1410
1411 UrlmonUrlRequestManager::ResourceFetcherThread::ResourceFetcherThread( 1411 UrlmonUrlRequestManager::ResourceFetcherThread::ResourceFetcherThread(
1412 const char* name) : base::Thread(name) { 1412 const char* name) : base::Thread(name) {
1413 } 1413 }
1414 1414
1415 UrlmonUrlRequestManager::ResourceFetcherThread::~ResourceFetcherThread() { 1415 UrlmonUrlRequestManager::ResourceFetcherThread::~ResourceFetcherThread() {
1416 Stop();
1416 } 1417 }
1417 1418
1418 void UrlmonUrlRequestManager::ResourceFetcherThread::Init() { 1419 void UrlmonUrlRequestManager::ResourceFetcherThread::Init() {
1419 CoInitialize(NULL); 1420 CoInitialize(NULL);
1420 } 1421 }
1421 1422
1422 void UrlmonUrlRequestManager::ResourceFetcherThread::CleanUp() { 1423 void UrlmonUrlRequestManager::ResourceFetcherThread::CleanUp() {
1423 CoUninitialize(); 1424 CoUninitialize();
1424 } 1425 }
1425 1426
OLDNEW
« no previous file with comments | « chrome_frame/test/urlmon_moniker_integration_test.cc ('k') | chrome_frame/utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698