Thread::Stop() must be called before any subclass's destructor completes.

base/threading/thread_unittest.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/thread.h"
 
 #include <vector>
 
 #include "base/message_loop.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 29 matching lines @@
   int msec_;
 };
 
 class SleepInsideInitThread : public Thread {
  public:
   SleepInsideInitThread() : Thread("none") {
     init_called_ = false;
     ANNOTATE_BENIGN_RACE(
         this, "Benign test-only data race on vptr - http://crbug.com/98219");
   }
-  virtual ~SleepInsideInitThread() { }
+  virtual ~SleepInsideInitThread() {
+    Stop();
+  }
 
   virtual void Init() {
     base::PlatformThread::Sleep(500);
     init_called_ = true;
   }
   bool InitCalled() { return init_called_; }
  private:
   bool init_called_;
 };
 
@@ skipping 16 matching lines @@
 class CaptureToEventList : public Thread {
  public:
   // This Thread pushes events into the vector |event_list| to show
   // the order they occured in. |event_list| must remain valid for the
   // lifetime of this thread.
   explicit CaptureToEventList(EventList* event_list)
       : Thread("none"), event_list_(event_list) {
   }
 
   virtual ~CaptureToEventList() {
-    // Must call Stop() manually to have our CleanUp() function called.
     Stop();
   }
 
   virtual void Init() {
     event_list_->push_back(THREAD_EVENT_INIT);
   }
 
   virtual void CleanUp() {
     event_list_->push_back(THREAD_EVENT_CLEANUP);
   }
@@ skipping 150 matching lines @@
 
     // Upon leaving this scope, the thread is deleted.
   }
 
   // Check the order of events during shutdown.
   ASSERT_EQ(static_cast<size_t>(THREAD_NUM_EVENTS), captured_events.size());
   EXPECT_EQ(THREAD_EVENT_INIT, captured_events[0]);
   EXPECT_EQ(THREAD_EVENT_CLEANUP, captured_events[1]);
   EXPECT_EQ(THREAD_EVENT_MESSAGE_LOOP_DESTROYED, captured_events[2]);
 }