Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 8427001: Fix unwanted implicit conversion from bool to int. (Closed)

Created:
9 years, 1 month ago by Steven
Modified:
9 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix unwanted implicit conversion from bool to int. We have the following signatures: VariableProxy* Scope::NewUnresolved(Handle<String> name, int position = RelocInfo::kNoPosition); bool Parser::inside_with() const; Committed: http://code.google.com/p/v8/source/detail?r=9850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Steven
μCL. PTAL.
9 years, 1 month ago (2011-10-31 14:43:48 UTC) #1
Yang
9 years, 1 month ago (2011-10-31 14:50:55 UTC) #2
On 2011/10/31 14:43:48, Steven wrote:
> μCL. PTAL.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698