Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 8426005: Merge IR classes for different bitwise operations AND, OR and XOR into one class. (Closed)

Created:
9 years, 1 month ago by fschneider
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Merge IR classes for different bitwise operations AND, OR and XOR into one class. Since we already have only one LIR class, it does not make much sense to separate them at the HIR level. Committed: http://code.google.com/p/v8/source/detail?r=9846

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -217 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +3 lines, -7 lines 0 comments Download
M src/arm/lithium-arm.cc View 3 chunks +18 lines, -34 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +13 lines, -42 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 3 chunks +5 lines, -46 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +3 lines, -7 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 3 chunks +19 lines, -35 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +3 lines, -7 lines 0 comments Download
M src/x64/lithium-x64.cc View 3 chunks +18 lines, -34 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 1 month ago (2011-10-31 12:19:15 UTC) #1
Kevin Millikin (Chromium)
9 years, 1 month ago (2011-10-31 12:52:00 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698