Histograms for DOMStorage access

Histograms for DOMStorage access


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108102

[cbentzel, 2011-10-31 12:41:34]

I'm interested in seeing how long access times to localStorage/sessionStorage
take.

[michaeln, 2011-10-31 14:37:03]

lgtm

[darin (slow to review), 2011-11-01 05:31:49]

LGTM

http://codereview.chromium.org/8426003/diff/1/content/renderer/renderer_webst...
File content/renderer/renderer_webstoragearea_impl.cc (right):

http://codereview.chromium.org/8426003/diff/1/content/renderer/renderer_webst...
content/renderer/renderer_webstoragearea_impl.cc:33:
UMA_HISTOGRAM_TIMES("DOMStorage.length", base::Time::Now() - start);
it seems like we should have a convenience macro for cases like this:

  UMA_HISTOGRAM_TIMES_FOR_SCOPE

it could lay down a class, who's constructor would initialize the start time,
and who's destructor would do what UMA_HISTOGRAM_TIMES does.

[cbentzel, 2011-11-01 11:37:52]

http://codereview.chromium.org/8426003/diff/1/content/renderer/renderer_webst...
File content/renderer/renderer_webstoragearea_impl.cc (right):

http://codereview.chromium.org/8426003/diff/1/content/renderer/renderer_webst...
content/renderer/renderer_webstoragearea_impl.cc:33:
UMA_HISTOGRAM_TIMES("DOMStorage.length", base::Time::Now() - start);
On 2011/11/01 05:31:49, darin wrote:
> it seems like we should have a convenience macro for cases like this:
> 
>   UMA_HISTOGRAM_TIMES_FOR_SCOPE
> 
> it could lay down a class, who's constructor would initialize the start time,
> and who's destructor would do what UMA_HISTOGRAM_TIMES does.

Yes. I'll see how common this is. Most of the timing histograms I've added have
straddled across async callbacks, so the macro would not be useful then unless
it could get tied to a scoped_ptr.

[commit-bot: I haz the power, 2011-11-01 11:41:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cbentzel@chromium.org/8426003/1

[commit-bot: I haz the power, 2011-11-01 12:52:38]

Change committed as 108102