chrome/browser/ui/webui/print_preview_data_source.cc - Issue 8425008: PrintPreview:[MAC] Added "Open PDF In Preview" option to open the pdf in native preview app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview_data_source.cc

Issue 8425008: PrintPreview:[MAC] Added "Open PDF In Preview" option to open the pdf in native preview app. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/print_preview.js ('K') | « chrome/browser/resources/print_preview/print_preview.js ('k') | chrome/browser/ui/webui/print_preview_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview_data_source.cc

diff --git a/chrome/browser/ui/webui/print_preview_data_source.cc b/chrome/browser/ui/webui/print_preview_data_source.cc

index 3621859cf76986986be52e6b397cdb326e5d5074..72f813aea35b9d58d118882aa7ed0e413983d62b 100644

--- a/chrome/browser/ui/webui/print_preview_data_source.cc

+++ b/chrome/browser/ui/webui/print_preview_data_source.cc

@@ -62,7 +62,10 @@ PrintPreviewDataSource::PrintPreviewDataSource()

AddLocalizedString("printing", IDS_PRINT_PREVIEW_PRINTING);

AddLocalizedString("printingToPDFInProgress",

IDS_PRINT_PREVIEW_PRINTING_TO_PDF_IN_PROGRESS);

+#if defined(OS_MACOSX)

+ AddLocalizedString("openingPDFInPreview",

+ IDS_PRINT_PREVIEW_OPENING_PDF_IN_PREVIEW);

+#endif

AddLocalizedString("destinationLabel", IDS_PRINT_PREVIEW_DESTINATION_LABEL);

AddLocalizedString("copiesLabel", IDS_PRINT_PREVIEW_COPIES_LABEL);

AddLocalizedString("examplePageRangeText",

@@ -106,6 +109,10 @@ PrintPreviewDataSource::PrintPreviewDataSource()

AddLocalizedString("printWithCloudPrint",

IDS_PRINT_PREVIEW_PRINT_WITH_CLOUD_PRINT);

#endif

+#if defined(OS_MACOSX)

+ AddLocalizedString("openPdfInPreviewOption",

+ IDS_PRINT_PREVIEW_OPEN_PDF_IN_PREVIEW_APP);

+#endif

AddLocalizedString("pageRangeInstruction",

IDS_PRINT_PREVIEW_PAGE_RANGE_INSTRUCTION);

AddLocalizedString("copiesInstruction", IDS_PRINT_PREVIEW_COPIES_INSTRUCTION);