Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 8425008: PrintPreview:[MAC] Added "Open PDF In Preview" option to open the pdf in native preview app. (Closed)

Created:
9 years, 1 month ago by kmadhusu
Modified:
9 years, 1 month ago
Reviewers:
csilv
CC:
chromium-reviews, dpapad
Visibility:
Public.

Description

PrintPreview:[MAC] Added "Open PDF In Preview" option to open the pdf in native preview app. BUG=101724 TEST=Preview a webpage. Click "Open PDF In Preview" option Observe that the pdf is displayed in native preview app. Complete the printing workflow by clicking "Print" or "Cancel" button at the bottom of the preview app. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110398

Patch Set 1 #

Patch Set 2 : Remove debug stmts #

Patch Set 3 : Temp patch #

Patch Set 4 : '' #

Patch Set 5 : Fixed #

Patch Set 6 : '' #

Total comments: 6

Patch Set 7 : Fixed nits #

Patch Set 8 : Added a check to fix the TestErrorMessage unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/preview_area.js View 1 2 3 4 5 6 7 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.css View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 1 2 3 4 5 6 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 2 3 4 5 6 9 chunks +54 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_data_source.cc View 1 2 3 4 5 6 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 1 2 3 4 5 6 1 chunk +8 lines, -3 lines 0 comments Download
M printing/print_job_constants.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M printing/print_job_constants.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M printing/printing_context_mac.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M printing/printing_context_mac.mm View 1 2 3 4 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kmadhusu
9 years, 1 month ago (2011-10-31 16:39:20 UTC) #1
kmadhusu
9 years, 1 month ago (2011-11-12 01:45:30 UTC) #2
csilv
lgtm http://codereview.chromium.org/8425008/diff/12012/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/8425008/diff/12012/chrome/app/generated_resources.grd#newcode6338 chrome/app/generated_resources.grd:6338: Opening PDF in Preview This should probably end ...
9 years, 1 month ago (2011-11-14 19:34:14 UTC) #3
kmadhusu
Fixed nits and addressed comments. Thanks. http://codereview.chromium.org/8425008/diff/12012/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/8425008/diff/12012/chrome/app/generated_resources.grd#newcode6338 chrome/app/generated_resources.grd:6338: Opening PDF in ...
9 years, 1 month ago (2011-11-16 17:59:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/8425008/17001
9 years, 1 month ago (2011-11-16 18:13:29 UTC) #5
commit-bot: I haz the power
Try job failure for 8425008-17001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
9 years, 1 month ago (2011-11-16 19:15:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/8425008/21001
9 years, 1 month ago (2011-11-16 22:40:09 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 23:56:04 UTC) #8
Try job failure for 8425008-21001 (retry) (retry) on linux_rel for step
"unit_tests".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698