Make the shadow for the fullscreen exit bubble for mac more prominent.

Make the shadow for the fullscreen exit bubble for mac more prominent.

xib changes: Add padding to the sides of the view to accommodate rendering a thick shadow around the edges of the fullscreen exit bubble.

BUG=100879
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109991

[Nico, 2011-10-31 06:51:46]

1.) Is there a bug for this? Is this ui-leads approved?
2.) CL description needs a "xib changes:" line
3.) I think this shows that thee fullscreen exit bubble shouldn't use a bubble
view but its own view class. Almost all of the normal bubble view is now
different for the fullscreen bubble.

[koz (OOO until 15th September), 2011-11-01 04:22:09]

On 2011/10/31 06:51:46, Nico wrote:
> 1.) Is there a bug for this? Is this ui-leads approved?
> 2.) CL description needs a "xib changes:" line
> 3.) I think this shows that thee fullscreen exit bubble shouldn't use a bubble
> view but its own view class. Almost all of the normal bubble view is now
> different for the fullscreen bubble.

1. Yes, sorry - I've updated the BUG= field. See the bug for more details.
2. Done.
3. Done.

[Nico, 2011-11-01 07:19:39]

The bug 403s for me, can you cc me?

Usually, window shadows are drawn by the window server, not by adding a view.
But it's probably fine in this case.

LGTM with the scoped_nsobject. Your call on the other comment.

http://codereview.chromium.org/8425007/diff/4012/chrome/browser/ui/cocoa/full...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm (right):

http://codereview.chromium.org/8425007/diff/4012/chrome/browser/ui/cocoa/full...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm:38: [NSGraphicsContext
saveGraphicsState];
Consider using ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h instead

http://codereview.chromium.org/8425007/diff/4012/chrome/browser/ui/cocoa/full...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm:48: [theShadow release];
Make theShadow a scoped_nsobject instead. Also, call it just shadow.

[koz (OOO until 15th September), 2011-11-01 23:52:14]

Thanks, Nico! I've CC'd you on the bug.

http://codereview.chromium.org/8425007/diff/4012/chrome/browser/ui/cocoa/full...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm (right):

http://codereview.chromium.org/8425007/diff/4012/chrome/browser/ui/cocoa/full...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm:38: [NSGraphicsContext
saveGraphicsState];
On 2011/11/01 07:19:39, Nico wrote:
> Consider using ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h instead

Done.

http://codereview.chromium.org/8425007/diff/4012/chrome/browser/ui/cocoa/full...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm:48: [theShadow release];
On 2011/11/01 07:19:39, Nico wrote:
> Make theShadow a scoped_nsobject instead. Also, call it just shadow.

Done.

[jeremya, 2011-11-09 00:37:18]

http://codereview.chromium.org/8425007/diff/11001/chrome/browser/ui/cocoa/ful...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm (right):

http://codereview.chromium.org/8425007/diff/11001/chrome/browser/ui/cocoa/ful...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm:41: [NSGraphicsContext
saveGraphicsState];
I don't think you need to saveGraphicsState *and* use a scoped graphics state...

[koz (OOO until 15th September), 2011-11-14 01:00:32]

http://codereview.chromium.org/8425007/diff/11001/chrome/browser/ui/cocoa/ful...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm (right):

http://codereview.chromium.org/8425007/diff/11001/chrome/browser/ui/cocoa/ful...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm:41: [NSGraphicsContext
saveGraphicsState];
On 2011/11/09 00:37:18, jeremya wrote:
> I don't think you need to saveGraphicsState *and* use a scoped graphics
state...

Done.

[commit-bot: I haz the power, 2011-11-14 23:03:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/8425007/19001

[commit-bot: I haz the power, 2011-11-15 00:20:29]

Change committed as 109991