Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: views/views.gyp

Issue 8425002: Introduces chromium_resources.gyp to factor out Chrome resource generation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/views.gyp
diff --git a/views/views.gyp b/views/views.gyp
index f212cbfad7e5e28823b4a490075dc3f954b90b10..494a82d4223d5461b622660ee3cf2199473d2c7d 100644
--- a/views/views.gyp
+++ b/views/views.gyp
@@ -546,6 +546,10 @@
'dependencies': [
'../base/base.gyp:base',
'../base/base.gyp:test_support_base',
+ # TODO(jcivelli): ideally the resource needed by views would be
sky 2011/10/31 14:34:00 nit: spacing is off here.
dhollowa 2011/10/31 14:41:15 Done. Tabs snuck in somehow.
+ # factored out. (for some reason it pulls in a bunch
+ # unrelated things like v8, sqlite nss...).
+ '../chrome/chrome_resources.gyp:packed_resources',
'../build/temp_gyp/googleurl.gyp:googleurl',
'../skia/skia.gyp:skia',
'../testing/gmock.gyp:gmock',
@@ -661,14 +665,6 @@
['exclude', '../ui/aura/test/test_desktop_delegate.h'],
],
}],
- ['OS!="mac"', {
- 'dependencies': [
- # TODO(jcivelli): ideally the resource needed by views would be
- # factored out. (for some reason it pulls in a bunch
- # unrelated things like v8, sqlite nss...).
- '../chrome/chrome.gyp:packed_resources',
- ],
- }],
],
},
{
@@ -677,6 +673,7 @@
'dependencies': [
'../base/base.gyp:base',
'../base/base.gyp:base_i18n',
+ '../chrome/chrome_resources.gyp:packed_resources',
'../skia/skia.gyp:skia',
'../third_party/icu/icu.gyp:icui18n',
'../third_party/icu/icu.gyp:icuuc',
@@ -776,11 +773,6 @@
'examples/table_example.h',
],
}],
- ['OS!="mac"', {
- 'dependencies': [
- '../chrome/chrome.gyp:packed_resources',
- ],
- }],
],
},
{
@@ -788,6 +780,7 @@
'type': 'static_library',
'dependencies': [
'../base/base.gyp:base',
+ '../chrome/chrome_resources.gyp:packed_resources',
'../skia/skia.gyp:skia',
'../third_party/icu/icu.gyp:icui18n',
'../third_party/icu/icu.gyp:icuuc',
@@ -833,11 +826,6 @@
'../third_party/wtl/include',
],
}],
- ['OS!="mac"', {
- 'dependencies': [
- '../chrome/chrome.gyp:packed_resources',
- ],
- }],
],
},
{
@@ -846,6 +834,7 @@
'dependencies': [
'../base/base.gyp:base',
'../base/base.gyp:base_i18n',
+ '../chrome/chrome_resources.gyp:packed_resources',
'../skia/skia.gyp:skia',
'../third_party/icu/icu.gyp:icui18n',
'../third_party/icu/icu.gyp:icuuc',
@@ -898,11 +887,6 @@
'../third_party/wtl/include',
],
}],
- ['OS!="mac"', {
- 'dependencies': [
- '../chrome/chrome.gyp:packed_resources',
- ],
- }],
],
},
],
@@ -915,6 +899,7 @@
'dependencies': [
'../base/base.gyp:base',
'../base/base.gyp:base_i18n',
+ '../chrome/chrome_resources.gyp:packed_resources',
'../skia/skia.gyp:skia',
'../third_party/icu/icu.gyp:icui18n',
'../third_party/icu/icu.gyp:icuuc',
@@ -946,11 +931,6 @@
'../third_party/wtl/include',
],
}],
- ['OS!="mac"', {
- 'dependencies': [
- '../chrome/chrome.gyp:packed_resources',
- ],
- }],
],
},
],
« chrome/chrome_repack_theme_resources_large.gypi ('K') | « ui/gfx/compositor/compositor.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698