Issue 8424008: TaskManager: Added "inspect" on context-menu on the task list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8424008: TaskManager: Added "inspect" on context-menu on the task list. (Closed)

Created:
9 years, 1 month ago by yoshiki

Modified:
9 years, 1 month ago

Reviewers:
pfeldman1, pfeldman

CC:
chromium-reviews, arv (Not doing code reviews), yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

TaskManager: Added "inspect" on context-menu on the task list. BUG=101718 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107935

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -0 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/table.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/task_manager/main.js	View	7 chunks	+73 lines, -0 lines	1 comment	Download
M	chrome/browser/ui/webui/task_manager_ui.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yoshiki

I created this new CL because of marge ToT. (cf. previous CL: http://codereview.chromium.org/8416026/publish) Could you ...

9 years, 1 month ago (2011-10-31 08:03:51 UTC) #1

pfeldman1

lgtm with a nit. http://codereview.chromium.org/8424008/diff/1/chrome/browser/resources/task_manager/main.js File chrome/browser/resources/task_manager/main.js (right): http://codereview.chromium.org/8424008/diff/1/chrome/browser/resources/task_manager/main.js#newcode435 chrome/browser/resources/task_manager/main.js:435: var classes = target.className.split(" "); ...

9 years, 1 month ago (2011-10-31 08:17:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/8424008/1

9 years, 1 month ago (2011-10-31 08:20:57 UTC) #3

Thanks!

Expand Messages | Collapse Messages