Issue 8424005: Loosen error reporting for hosted app permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8424005: Loosen error reporting for hosted app permissions. (Closed)

Created:
9 years, 1 month ago by Aaron Boodman

Modified:
9 years, 1 month ago

Reviewers:
jstritar

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Loosen error reporting for hosted app permissions. BUG=101993 TEST=https://chrome.google.com/webstore/detail/imjhdahelgojehmfmkmdfjcpfbglbfmj should install without error. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108013

Patch Set 1 #

Patch Set 2 : moar test #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -13 lines)			Patch
	M	chrome/common/extensions/extension.cc	View		2 chunks	+14 lines, -4 lines	1 comment	Download
	M	chrome/common/extensions/extension_manifests_unittest.cc	View	1	1 chunk	+35 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jstritar

LGTM http://codereview.chromium.org/8424005/diff/1003/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/8424005/diff/1003/chrome/common/extensions/extension.cc#newcode2576 chrome/common/extensions/extension.cc:2576: if (!error->empty()) nit: I think you can make ...

9 years, 1 month ago (2011-10-31 19:16:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8424005/1003

9 years, 1 month ago (2011-10-31 20:05:41 UTC) #4

Change committed as 108013

Expand Messages | Collapse Messages