Issue 8424004: Revert log change to thread_local_win to fix an internal compiler error when

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8424004: Revert log change to thread_local_win to fix an internal compiler error when (Closed)

Created:
9 years, 1 month ago by brettw

Modified:
8 years, 7 months ago

Reviewers:
laforge

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert log change to thread_local_win to fix an internal compiler error when doing official Chrome builds. TBR=1aforge Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107910

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/threading/thread_local_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pdwiki

8 years, 7 months ago (2012-05-18 12:15:17 UTC) #2

I am still getting this error in Developer Build 97580. I did update the
thread_local_win.cc but the internal compiler error persists. Can you let me
know if this fix only works from a certain developer build onwards? Below is
part of the error message:


19>------ Build started: Project: chrome, Configuration: Release Win32 ------
19>     Creating library D:\chromium.r87272\src\build\Release\lib\chrome_exe.lib
and object D:\chromium.r87272\src\build\Release\lib\chrome_exe.exp
19>  Generating code
19>d:\chromium.r87272\src\base\threading\thread_local_win.cc(41): fatal error
C1001: An internal error has occurred in the compiler.
19>  (compiler file
'f:\dd\vctools\compiler\utc\src\p2\main.c[0x6172F4B0:0x00000000]', line 183)
19>   To work around this problem, try simplifying or changing the program near
the locations listed above.

Expand Messages | Collapse Messages