chromeos: Split NetworkChangeNotifierChromeos initialization.

chrome/browser/chromeos/net/network_change_notifier_chromeos.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/net/network_change_notifier_chromeos.h"
 
 #include "base/bind.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "content/public/browser/browser_thread.h"
 
@@ skipping 47 matching lines @@
   NetworkChangeNotifierChromeos* parent_;
   bool is_online_;
   bool should_report_;
 };
 
 NetworkChangeNotifierChromeos::NetworkChangeNotifierChromeos()
     : has_active_network_(false),
       connection_state_(chromeos::STATE_UNKNOWN),
       online_notification_task_(NULL) {
 
-  chromeos::NetworkLibrary* net =
-      chromeos::CrosLibrary::Get()->GetNetworkLibrary();
-  net->AddNetworkManagerObserver(this);
-
-  chromeos::PowerLibrary* power =
-      chromeos::CrosLibrary::Get()->GetPowerLibrary();
-  power->AddObserver(this);
-
-  UpdateNetworkState(net);

[satorux1, 2011/11/03 20:13:54]

So I thought the removal of the line 76 was harmless as net->active_network() is
NULL by the time this is called, which is true in production.

However, for tests on Linux desktop, net->active_network() is non-NULL here, and
removing the line breaks many tests in browser_tests.

Now thinking about how to fix this...

   BrowserThread::PostDelayedTask(
          BrowserThread::UI, FROM_HERE,
          base::Bind(
              &NetworkChangeNotifierChromeos::UpdateInitialState, this),
          kInitialNotificationCheckDelayMS);
 }
 
 NetworkChangeNotifierChromeos::~NetworkChangeNotifierChromeos() {
   if (online_notification_task_) {
     online_notification_task_->Cancel();
@@ skipping 163 matching lines @@
 }
 
 // static
 void NetworkChangeNotifierChromeos::UpdateInitialState(
     NetworkChangeNotifierChromeos* self) {
   chromeos::NetworkLibrary* net =
       chromeos::CrosLibrary::Get()->GetNetworkLibrary();
   self->UpdateNetworkState(net);
 }
 
-}  // namespace net
+}  // namespace chromeos