Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6346)

Unified Diff: chrome/browser/ui/panels/panel_browser_view.cc

Issue 8423060: Classification of TODOs in Panel code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr feedback Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_view.cc
diff --git a/chrome/browser/ui/panels/panel_browser_view.cc b/chrome/browser/ui/panels/panel_browser_view.cc
index de26f11cd2a80ebf9fd86658f0f8e7714df63f37..fe84d774019a734c6e51613234fe1040956c6771 100644
--- a/chrome/browser/ui/panels/panel_browser_view.cc
+++ b/chrome/browser/ui/panels/panel_browser_view.cc
@@ -93,7 +93,7 @@ void PanelBrowserView::Deactivate() {
else
::SetFocus(NULL);
#else
- // TODO(jianli): to be implemented for other platform.
+ NOTIMPLEMENTED();
BrowserView::Deactivate();
#endif
}
@@ -146,17 +146,13 @@ void PanelBrowserView::OnWidgetActivationChanged(views::Widget* widget,
bool active) {
::BrowserView::OnWidgetActivationChanged(widget, active);
-#if defined(USE_AURA)
- // TODO(beng):
- NOTIMPLEMENTED();
- bool focused = active;
-#elif defined(OS_WIN)
+#if defined(OS_WIN) && !defined(USE_AURA)
// The panel window is in focus (actually accepting keystrokes) if it is
// active and belongs to a foreground application.
bool focused = active &&
GetFrameView()->GetWidget()->GetNativeView() == ::GetForegroundWindow();
#else
- // TODO(jianli): Investigate focus behavior for ChromeOS
+ NOTIMPLEMENTED();
bool focused = active;
#endif
@@ -511,7 +507,7 @@ void NativePanelTestingWin::ReleaseMouseButtonTitlebar() {
void NativePanelTestingWin::DragTitlebar(int delta_x, int delta_y) {
// TODO(jianli): Need a comment here that explains why we use
// mouse_pressed_point_ and not current bounds as obtained by
- // GetRestoredBounds().
+ // GetRestoredBounds(). http://crbug.com/102730
panel_browser_view_->OnTitlebarMouseDragged(gfx::Point(
panel_browser_view_->mouse_pressed_point_.x() + delta_x,
panel_browser_view_->mouse_pressed_point_.y() + delta_y));
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_frame_view.cc ('k') | chrome/browser/ui/panels/panel_browser_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698