Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 8423060: Classification of TODOs in Panel code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr feedback Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel.cc
diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc
index 9f4f1a2baba07f17a8626cbb758c239e77d9245c..99c4ae2ddd5b22a162ec2b9adbfce0f10ca1b980 100644
--- a/chrome/browser/ui/panels/panel.cc
+++ b/chrome/browser/ui/panels/panel.cc
@@ -172,7 +172,7 @@ void Panel::Close() {
// TODO(dimich): Only implemented fully async on Mac. Need to update other
// platforms. The panel should be removed from PanelManager when and if it
// was actually closed. The closing can be cancelled because of onbeforeunload
-// handler on the web page.
+// handler on the web page. http://crbug.com/102720
#if !defined(OS_MACOSX)
manager()->Remove(this);
#endif
@@ -207,7 +207,7 @@ BrowserWindowTesting* Panel::GetBrowserWindowTesting() {
}
StatusBubble* Panel::GetStatusBubble() {
- // TODO(jennb): Implement.
+ // TODO(jennb): Implement. http://crbug.com/102723
return NULL;
}
@@ -233,7 +233,8 @@ void Panel::UpdateLoadingAnimations(bool should_animate) {
}
void Panel::SetStarredState(bool is_starred) {
- // TODO(jennb): Figure out if this applies to Panels.
+ // Since panels are typically not bookmarked extension UI windows, they don't
+ // have starred state.
}
gfx::Rect Panel::GetRestoredBounds() const {
@@ -248,7 +249,7 @@ gfx::Rect Panel::GetBounds() const {
}
bool Panel::IsMaximized() const {
- // TODO(jennb): Figure out how this applies to Panels. Means isZoomed.
+ // Size of panels is managed by PanelManager, they are never 'zoomed'.
return false;
}
@@ -290,7 +291,7 @@ void Panel::SetFocusToLocationBar(bool select_all) {
}
void Panel::UpdateReloadStopState(bool is_loading, bool force) {
- // TODO(jennb): Implement.
+ // Panels don't have stop/reload indicator.
}
void Panel::UpdateToolbar(TabContentsWrapper* contents,
« no previous file with comments | « chrome/browser/ui/panels/base_panel_browser_test.cc ('k') | chrome/browser/ui/panels/panel_browser_frame_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698