Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: chrome/browser/ui/panels/panel_browser_window_gtk.cc

Issue 8423060: Classification of TODOs in Panel code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr feedback Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/panels/panel_browser_window_gtk.h" 5 #include "chrome/browser/ui/panels/panel_browser_window_gtk.h"
6 6
7 #include "chrome/browser/ui/browser_list.h" 7 #include "chrome/browser/ui/browser_list.h"
8 #include "chrome/browser/ui/panels/panel.h" 8 #include "chrome/browser/ui/panels/panel.h"
9 #include "chrome/browser/ui/panels/panel_manager.h" 9 #include "chrome/browser/ui/panels/panel_manager.h"
10 #include "chrome/browser/ui/panels/panel_settings_menu_model.h" 10 #include "chrome/browser/ui/panels/panel_settings_menu_model.h"
(...skipping 687 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 698
699 bool NativePanelTestingGtk::VerifyDrawingAttention() const { 699 bool NativePanelTestingGtk::VerifyDrawingAttention() const {
700 std::string title; 700 std::string title;
701 BrowserWindowGtk::TitleDecoration decoration = 701 BrowserWindowGtk::TitleDecoration decoration =
702 panel_browser_window_gtk_->GetWindowTitle(&title); 702 panel_browser_window_gtk_->GetWindowTitle(&title);
703 return panel_browser_window_gtk_->IsDrawingAttention() && 703 return panel_browser_window_gtk_->IsDrawingAttention() &&
704 decoration == BrowserWindowGtk::PANGO_MARKUP; 704 decoration == BrowserWindowGtk::PANGO_MARKUP;
705 } 705 }
706 706
707 bool NativePanelTestingGtk::VerifyActiveState(bool is_active) { 707 bool NativePanelTestingGtk::VerifyActiveState(bool is_active) {
708 // TODO(jianli): to be implemented. 708 // TODO(jianli): to be implemented. http://crbug.com/102737
709 return false; 709 return false;
710 } 710 }
711 711
712 void NativePanelTestingGtk::WaitForWindowCreationToComplete() const { 712 void NativePanelTestingGtk::WaitForWindowCreationToComplete() const {
713 while (!panel_browser_window_gtk_->window_size_known_) 713 while (!panel_browser_window_gtk_->window_size_known_)
714 MessageLoopForUI::current()->RunAllPending(); 714 MessageLoopForUI::current()->RunAllPending();
715 while (panel_browser_window_gtk_->bounds_animator_.get() && 715 while (panel_browser_window_gtk_->bounds_animator_.get() &&
716 panel_browser_window_gtk_->bounds_animator_->is_animating()) { 716 panel_browser_window_gtk_->bounds_animator_->is_animating()) {
717 MessageLoopForUI::current()->RunAllPending(); 717 MessageLoopForUI::current()->RunAllPending();
718 } 718 }
719 } 719 }
720 720
721 bool NativePanelTestingGtk::IsWindowSizeKnown() const { 721 bool NativePanelTestingGtk::IsWindowSizeKnown() const {
722 return panel_browser_window_gtk_->window_size_known_; 722 return panel_browser_window_gtk_->window_size_known_;
723 } 723 }
724 724
725 bool NativePanelTestingGtk::IsAnimatingBounds() const { 725 bool NativePanelTestingGtk::IsAnimatingBounds() const {
726 return panel_browser_window_gtk_->IsAnimatingBounds(); 726 return panel_browser_window_gtk_->IsAnimatingBounds();
727 } 727 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_view_browsertest.cc ('k') | chrome/browser/ui/panels/panel_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698