Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 8423041: Revert 108258 - broke Mac LayoutTests. (Closed)

Created:
9 years, 1 month ago by kinuko
Modified:
9 years, 1 month ago
Reviewers:
kinuko
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 108258 - broke Mac LayoutTests. Merge FileUtilProxy and FileSystemFileUtilProxy using PostTaskAndReply: CreateOrOpen/Close Deprecating MessageProxyRelay class and getting rid of duplicated code. BUG=none TEST=test_shell_tests:\*FileSystem\* Review URL: http://codereview.chromium.org/8424006 TBR=kinuko@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -131 lines) Patch
M base/file_util_proxy.h View 3 chunks +1 line, -17 lines 0 comments Download
M base/file_util_proxy.cc View 8 chunks +26 lines, -83 lines 0 comments Download
M webkit/fileapi/file_system_file_util_proxy.h View 2 chunks +18 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_file_util_proxy.cc View 3 chunks +83 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_operation.cc View 3 chunks +10 lines, -31 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kinuko
9 years, 1 month ago (2011-11-02 12:14:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698