Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 8423035: Split out fullscreen logic from Browser into FullscreenController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
index 6b1b939a2ffdfc3aa2c987f0121c91f66339c0c4..0c6635b9444d7f001dbe13f31b215e6a13c74155 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
@@ -688,6 +688,7 @@ static bool IsFrontWindow(NSWindow *window) {
}
TEST_F(BrowserWindowFullScreenControllerTest, TestFullscreenNotLion) {
+ CreateBrowserWindow();
EXPECT_FALSE([controller_ isFullscreen]);
[controller_ enterFullscreenForURL:GURL()
bubbleType:FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION];
@@ -701,6 +702,7 @@ TEST_F(BrowserWindowFullScreenControllerTest, TestFullscreenNotLion) {
// please do not mark it as flaky without first verifying that there are no bot
// problems.
TEST_F(BrowserWindowFullScreenControllerTest, TestActivateNotLion) {
+ CreateBrowserWindow();
EXPECT_FALSE([controller_ isFullscreen]);
[controller_ activate];

Powered by Google App Engine
This is Rietveld 408576698