Issue 8423031: Fix failing policy_prefs_ui tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8423031: Fix failing policy_prefs_ui tests (Closed)

Created:
9 years, 1 month ago by flackr

Modified:
9 years, 1 month ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey, bshe

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

This fixes the failing policy_prefs_ui tests testTogglePolicyTogglesBanner and testPoliciesShowBanner and re-enables these tests. BUG=102546 TEST=policy_prefs_ui Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108230

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/resources/options/options_page.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/test/functional/PYAUTO_TESTS	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Nirnimesh

9 years, 1 month ago (2011-11-02 01:32:25 UTC) #2

LGTM, but please change the title/description to say that this is a fix, not
just a revert.