Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 8423025: Add bug #s and remove NOTIMPLEMENTED()s for things we don't need to implement in RWHVA (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
===================================================================
--- content/browser/renderer_host/render_widget_host_view_aura.cc (revision 108176)
+++ content/browser/renderer_host/render_widget_host_view_aura.cc (working copy)
@@ -213,10 +213,12 @@
void RenderWidgetHostViewAura::TextInputStateChanged(
ui::TextInputType type,
bool can_compose_inline) {
+ // http://crbug.com/102569
NOTIMPLEMENTED();
}
void RenderWidgetHostViewAura::ImeCancelComposition() {
+ // http://crbug.com/102569
NOTIMPLEMENTED();
}
@@ -332,22 +334,23 @@
void RenderWidgetHostViewAura::SetVisuallyDeemphasized(const SkColor* color,
bool animate) {
+ // http://crbug.com/102568
NOTIMPLEMENTED();
}
void RenderWidgetHostViewAura::UnhandledWheelEvent(
const WebKit::WebMouseWheelEvent& event) {
- NOTIMPLEMENTED();
+ // Not needed. Mac-only.
}
void RenderWidgetHostViewAura::SetHasHorizontalScrollbar(
bool has_horizontal_scrollbar) {
- NOTIMPLEMENTED();
+ // Not needed. Mac-only.
}
void RenderWidgetHostViewAura::SetScrollOffsetPinning(
bool is_pinned_to_left, bool is_pinned_to_right) {
- NOTIMPLEMENTED();
+ // Not needed. Mac-only.
}
#if defined(OS_WIN)
@@ -379,11 +382,13 @@
#endif
bool RenderWidgetHostViewAura::LockMouse() {
+ // http://crbug.com/102563
NOTIMPLEMENTED();
return false;
}
void RenderWidgetHostViewAura::UnlockMouse() {
+ // http://crbug.com/102563
NOTIMPLEMENTED();
host_->LostMouseLock();
}
@@ -417,8 +422,8 @@
}
gfx::NativeCursor RenderWidgetHostViewAura::GetCursor(const gfx::Point& point) {
- // TODO(beng): talk to beng before implementing this.
- //NOTIMPLEMENTED();
+ // http://crbug.com/102562
+ // NOTIMPLEMENTED();
return gfx::kNullCursor;
}
@@ -509,6 +514,7 @@
// RenderWidgetHostViewAura, private:
void RenderWidgetHostViewAura::UpdateCursorIfOverSelf() {
- //NOTIMPLEMENTED();
+ // http://crbug.com/102562
+ // NOTIMPLEMENTED();
// TODO(beng): See RenderWidgetHostViewWin.
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698