Issue 8423018: Make ContinueWindow on Mac terminate after timeout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8423018: Make ContinueWindow on Mac terminate after timeout (Closed)

Created:
9 years, 1 month ago by dmac

Modified:
9 years, 1 month ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Make ContinueWindow on Mac terminate after timeout BUG=100928 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108182

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix up Jamie's nits #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -64 lines)			Patch
	M	remoting/host/continue_window_mac.mm	View	1	1 chunk	+91 lines, -64 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jamie

LGTM with one nit. http://codereview.chromium.org/8423018/diff/1/remoting/host/continue_window_mac.mm File remoting/host/continue_window_mac.mm (right): http://codereview.chromium.org/8423018/diff/1/remoting/host/continue_window_mac.mm#newcode81 remoting/host/continue_window_mac.mm:81: NSWindow* window = Should this ...

9 years, 1 month ago (2011-11-01 20:56:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmaclach@chromium.org/8423018/2003

9 years, 1 month ago (2011-11-01 21:04:00 UTC) #3

Change committed as 108182

Expand Messages | Collapse Messages