Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 8423008: Fixed touch build after 8395042. (Closed)

Created:
9 years, 1 month ago by altimofeev
Modified:
9 years, 1 month ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, nkostylev+watch_chromium.org, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fixed touch build after 8395042. Also used better way of getting top widget for the bubble. BUG=none TEST=touch compiles and touch tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108145

Patch Set 1 #

Patch Set 2 : get rid of GTK_WINDOW #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/browser/chromeos/setting_level_bubble.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
altimofeev
9 years, 1 month ago (2011-11-01 17:14:52 UTC) #1
cwolfe
Thanks for the quick fix. Works for me.
9 years, 1 month ago (2011-11-01 17:30:13 UTC) #2
Nikita (slow)
lgtm
9 years, 1 month ago (2011-11-01 17:56:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/altimofeev@chromium.org/8423008/6
9 years, 1 month ago (2011-11-01 17:57:32 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 19:06:38 UTC) #5
Change committed as 108145

Powered by Google App Engine
This is Rietveld 408576698