Enable experimental permissions for extensions from the store.

chrome/browser/extensions/crx_installer.h

Index: chrome/browser/extensions/crx_installer.h
diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h
index e83342d7041c317a9f5e1ee66c78ad40fe86ae9b..450dd5ed60607807d8d46234281bcc69b15b936d 100644
--- a/chrome/browser/extensions/crx_installer.h
+++ b/chrome/browser/extensions/crx_installer.h
@@ -137,8 +137,13 @@ class CrxInstaller
   bool allow_silent_install() const { return allow_silent_install_; }
   void set_allow_silent_install(bool val) { allow_silent_install_ = val; }
 
-  bool is_gallery_install() const { return is_gallery_install_; }
-  void set_is_gallery_install(bool val) { is_gallery_install_ = val; }
+  bool is_gallery_install() const {
+    return creation_flags_ & Extension::FROM_WEBSTORE;

[Matt Perry, 2011/10/31 18:55:14]

was this a functional change, or just a cleanup?

[Aaron Boodman, 2011/10/31 20:04:12]

The overall change is a functional addition. The previous attempt to allow store
extensions to specify experimental permissions did not work because
FROM_WEBSTORE was not passed down into ExtensionUnpacker.

In this particular case, I didn't like the fact that we were essentially storing
is_gallery_install() two ways (the boolean flag and the bit in creation_flags),
so I combined them.

+  }
+  void set_is_gallery_install(bool val) {
+    if (val) creation_flags_ |= Extension::FROM_WEBSTORE;
+    else creation_flags_ &= ~Extension::FROM_WEBSTORE;
+  }
 
   // The original download URL should be set when the WebstoreInstaller is
   // tracking the installation. The WebstoreInstaller uses this URL to match
@@ -247,9 +252,6 @@ class CrxInstaller
   // to false.
   bool delete_source_;
 
-  // Whether the install originated from the gallery.
-  bool is_gallery_install_;
-
   // The download URL, before redirects, if this is a gallery install.
   GURL original_download_url_;