Issue 8423003: Enable experimental permissions for extensions from the store.

Issue 8423003: Enable experimental permissions for extensions from the store. (Closed)

Created:
9 years, 1 month ago by Aaron Boodman

Modified:
9 years, 1 month ago

Reviewers:
Roger Tawa OOO till Jul 10th, Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr., Roger Tawa OOO till Jul 10th

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Enable experimental permissions for extensions from the store. BUG=100895 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108039

Patch Set 2 : little cleanup #

Total comments: 2

Patch Set 3 : Fix Windows compile warning #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -31 lines)			Patch
M	chrome/browser/extensions/crx_installer.h	View	1 2	2 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.cc	View		5 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer_browsertest.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_browsertest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.h	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.cc	View		5 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/common/chrome_utility_messages.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_unpacker.h	View		3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension_unpacker.cc	View		2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/extension_unpacker_unittest.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
A	chrome/test/data/extensions/experimental.crx	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/utility/chrome_content_utility_client.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/utility/chrome_content_utility_client.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

Matt: please review Roger: just including you because you recently and might have better eyes ...

9 years, 1 month ago (2011-10-31 07:10:37 UTC) #1

Matt Perry

lgtm http://codereview.chromium.org/8423003/diff/2001/chrome/browser/extensions/crx_installer.h File chrome/browser/extensions/crx_installer.h (right): http://codereview.chromium.org/8423003/diff/2001/chrome/browser/extensions/crx_installer.h#newcode141 chrome/browser/extensions/crx_installer.h:141: return creation_flags_ & Extension::FROM_WEBSTORE; was this a functional ...

9 years, 1 month ago (2011-10-31 18:55:14 UTC) #3

Aaron Boodman

http://codereview.chromium.org/8423003/diff/2001/chrome/browser/extensions/crx_installer.h File chrome/browser/extensions/crx_installer.h (right): http://codereview.chromium.org/8423003/diff/2001/chrome/browser/extensions/crx_installer.h#newcode141 chrome/browser/extensions/crx_installer.h:141: return creation_flags_ & Extension::FROM_WEBSTORE; On 2011/10/31 18:55:14, Matt Perry ...

9 years, 1 month ago (2011-10-31 20:04:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8423003/2001

9 years, 1 month ago (2011-10-31 20:04:32 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8423003/8001

9 years, 1 month ago (2011-10-31 22:34:23 UTC) #6

Change committed as 108039

Expand Messages | Collapse Messages