Adds a bubble that asks a user whether to integrate the Spelling service.

Adds a bubble that asks a user whether to integrate the Spelling service.
This change implements the final UI that integrates the Spelling service into Chrome on Windows to measure actual QPS to the spelling service with Windows Chrome. This UI updatee consists of three parts:
* Add a context-menu item "Ask Google for spelling suggestions";
* Show a bubble when a user chosses the item, and;
* Hide the suggestions from the Spelling service if it is in the suggestion list of the local spellchecker.

BUG=93746
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108096

[Avi (use Gerrit), 2011-10-31 13:24:43]

lgtm

[Miranda Callahan, 2011-10-31 13:33:45]

LGTM with a few comments.

http://codereview.chromium.org/8422006/diff/5007/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8422006/diff/5007/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:496: <message
name="IDS_CONTENT_CONTEXT_SPELLING_BUBBLE_DISABLE" desc="The button text that
disallows integrattng the spelling service of Google.">
nit: s/integrattng/integrating

http://codereview.chromium.org/8422006/diff/5007/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/spelling_bubble_model.cc (right):

http://codereview.chromium.org/8422006/diff/5007/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spelling_bubble_model.cc:13: #include
"ui/base/l10n/l10n_util.h"
nit: alpha-order

http://codereview.chromium.org/8422006/diff/5007/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spelling_bubble_model.cc:44: if (pref)
Maybe change this to a DCHECK? If a Profile doesn't have a PrefService, there
are serious problems...

http://codereview.chromium.org/8422006/diff/5007/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/spelling_menu_observer.cc (right):

http://codereview.chromium.org/8422006/diff/5007/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spelling_menu_observer.cc:107: if (command_id ==
IDC_CONTENT_CONTEXT_SPELLING_SUGGESTION)
Maybe change the last three lines to:

return (command_id == IDC_CONTENT_CONTEXT_SPELLING_SUGGESTION)

[Hironori Bono, 2011-11-01 10:15:09]

Greetings Avi and Miranda,

Thank you so much for your review and comments. I have applied your comments and
sent the updated change to the commit queue.

Regards,

Hironori Bono

http://codereview.chromium.org/8422006/diff/5007/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8422006/diff/5007/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:496: <message
name="IDS_CONTENT_CONTEXT_SPELLING_BUBBLE_DISABLE" desc="The button text that
disallows integrattng the spelling service of Google.">
On 2011/10/31 13:33:46, Miranda Callahan wrote:
> nit: s/integrattng/integrating

Done. Thank you for noticing my typo.

http://codereview.chromium.org/8422006/diff/5007/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/spelling_bubble_model.cc (right):

http://codereview.chromium.org/8422006/diff/5007/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spelling_bubble_model.cc:13: #include
"ui/base/l10n/l10n_util.h"
On 2011/10/31 13:33:46, Miranda Callahan wrote:
> nit: alpha-order

Done. Thanks for noticing it.

http://codereview.chromium.org/8422006/diff/5007/chrome/browser/tab_contents/...
chrome/browser/tab_contents/spelling_bubble_model.cc:44: if (pref)
On 2011/10/31 13:33:46, Miranda Callahan wrote:
> Maybe change this to a DCHECK? If a Profile doesn't have a PrefService, there
> are serious problems...

Done. Thank you for your explanation. (I did not notice it.)

[commit-bot: I haz the power, 2011-11-01 10:15:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hbono@chromium.org/8422006/8001

[commit-bot: I haz the power, 2011-11-01 11:23:37]

Change committed as 108096