Issue 8422003: Disable SSLClientSocketTest.ConnectExpired on the "Windows Tests (tsan)" bot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8422003: Disable SSLClientSocketTest.ConnectExpired on the "Windows Tests (tsan)" bot. (Closed)

Created:
9 years, 1 month ago by Hironori Bono

Modified:
9 years, 1 month ago

Reviewers:
Lei Zhang, Alexander Potapenko, Timur Iskhodzhanov

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable SSLClientSocketTest.ConnectExpired on the "Windows Tests (tsan)" bot. This change just disables the SSLClientSocketTest.ConnectExpired, which has been failing somehow since Build 102330. TBR=timurrrr,glider,thestig BUG=102330 TEST=make the "Windows Tests (tsan)" bot green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107923

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

9 years, 1 month ago (2011-10-31 07:17:09 UTC) #2

LGTM
31.10.2011 8:39 пользователь <hbono@chromium.org> написал:

> Reviewers: Timur Iskhodzhanov, Alexander Potapenko, Lei Zhang,
>
> Description:
> Disable SSLClientSocketTest.**ConnectExpired on the "Windows Tests
> (tsan)" bot.
> This change just disables the SSLClientSocketTest.**ConnectExpired, which
> has been
> failing somehow since Build 102330.
>
> TBR=timurrrr,glider,thestig
> BUG=102330
> TEST=make the "Windows Tests (tsan)" bot green.
>
> Please review this at
http://codereview.chromium.**org/8422003/<http://codereview.chromium.org/8422...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     tools/valgrind/gtest_exclude/**net_unittests.gtest-tsan_**win32.txt
>
>
> Index: tools/valgrind/gtest_exclude/**net_unittests.gtest-tsan_**win32.txt
> ==============================**==============================**=======
> --- tools/valgrind/gtest_exclude/**net_unittests.gtest-tsan_**win32.txt
>   (revision 107915)
> +++ tools/valgrind/gtest_exclude/**net_unittests.gtest-tsan_**win32.txt
>   (working copy)
> @@ -32,3 +32,6 @@
>  # Time out, see http://crbug.com/68482
>  SSLServerSocketTest.*
>  X509CertificateTest.**TestKnownRoot
> +
> +# See http://crbug.com/102330
> +SSLClientSocketTest.**ConnectExpired
>
>
>

Expand Messages | Collapse Messages