Issue 8418041: Fix the JavascriptWindow open CF tests which failed because the pending render view status was not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8418041: Fix the JavascriptWindow open CF tests which failed because the pending render view status was not (Closed)

Created:
9 years, 1 month ago by ananta

Modified:
9 years, 1 month ago

Reviewers:
robertshield

CC:
chromium-reviews, robertshield, kkania, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix the JavascriptWindow open CF tests which failed because the pending render view status was not propagated correctly. BUG=ChromeFrame tests should now pass on IE8. TBR=robertshield Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107832

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/automation/automation_resource_message_filter.cc	View		2 chunks	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertshield

http://codereview.chromium.org/8418041/diff/1/chrome/browser/automation/automation_resource_message_filter.cc File chrome/browser/automation/automation_resource_message_filter.cc (right): http://codereview.chromium.org/8418041/diff/1/chrome/browser/automation/automation_resource_message_filter.cc#newcode282 chrome/browser/automation/automation_resource_message_filter.cc:282: automation_details_iter->second.is_pending_render_view = pending_view; looking at AutomationDetails, there are two ...

9 years, 1 month ago (2011-10-29 01:02:35 UTC) #2

lgtm

Expand Messages | Collapse Messages