Issue 8418039: Get web-app name, MIME type and description from gyp file for all platforms, and brand correctly.

Issue 8418039: Get web-app name, MIME type and description from gyp file for all platforms, and brand correctly. (Closed)

Created:
9 years, 1 month ago by Jamie

Modified:
9 years, 1 month ago

Reviewers:
dmac, Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Get web-app name, MIME type and description from gyp file for all platforms, and brand correctly. BUG=101469 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107986

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -53 lines)			Patch
M	remoting/host/plugin/host_plugin.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	remoting/host/plugin/host_plugin.rc	View		3 chunks	+2 lines, -42 lines	0 comments	Download
M	remoting/host/plugin/host_plugin-Info.plist	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	remoting/host/plugin/host_plugin_version.rc	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download
M	remoting/remoting.gyp	View	1	5 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Wez

LGTM w/ a couple of nits. http://codereview.chromium.org/8418039/diff/1/remoting/host/plugin/host_plugin_version.rc File remoting/host/plugin/host_plugin_version.rc (right): http://codereview.chromium.org/8418039/diff/1/remoting/host/plugin/host_plugin_version.rc#newcode7 remoting/host/plugin/host_plugin_version.rc:7: // that Visual ...

9 years, 1 month ago (2011-10-29 00:17:47 UTC) #2

dmac

9 years, 1 month ago (2011-10-31 15:40:20 UTC) #3

On 2011/10/29 00:17:47, Wez wrote:
> LGTM w/ a couple of nits.
> 
>
http://codereview.chromium.org/8418039/diff/1/remoting/host/plugin/host_plugi...
> File remoting/host/plugin/host_plugin_version.rc (right):
> 
>
http://codereview.chromium.org/8418039/diff/1/remoting/host/plugin/host_plugi...
> remoting/host/plugin/host_plugin_version.rc:7: // that Visual Studio will not
> try to change it.
> nit: Can this be worded more clearly?
> 
> http://codereview.chromium.org/8418039/diff/1/remoting/remoting.gyp
> File remoting/remoting.gyp (right):
> 
> http://codereview.chromium.org/8418039/diff/1/remoting/remoting.gyp#newcode10
> remoting/remoting.gyp:10: # Use a consistent strings across all platforms.
Note
> that the plugin name
> typo: a consistent strings

LGTM

Expand Messages | Collapse Messages