Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: chrome/browser/chromeos/login/update_screen_browsertest.cc

Issue 8418037: chromeos: Fix UpdateScreenTest and NetworkScreenTest for Debug build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/signed_settings_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/update_screen_browsertest.cc
diff --git a/chrome/browser/chromeos/login/update_screen_browsertest.cc b/chrome/browser/chromeos/login/update_screen_browsertest.cc
index a88e20515bee2c94088f700a0f9c73d0672b83f1..53f64bf50cad76665d91219747f70692fc90c000 100644
--- a/chrome/browser/chromeos/login/update_screen_browsertest.cc
+++ b/chrome/browser/chromeos/login/update_screen_browsertest.cc
@@ -5,7 +5,7 @@
#include "base/message_loop.h"
#include "chrome/browser/chromeos/cros/mock_network_library.h"
#include "chrome/browser/chromeos/cros/mock_update_library.h"
-#include "chrome/browser/chromeos/dbus/dbus_thread_manager.h"
+#include "chrome/browser/chromeos/dbus/mock_dbus_thread_manager.h"
#include "chrome/browser/chromeos/dbus/mock_session_manager_client.h"
#include "chrome/browser/chromeos/login/mock_screen_observer.h"
#include "chrome/browser/chromeos/login/update_screen.h"
@@ -28,22 +28,22 @@ static void RequestUpdateCheckSuccess(UpdateCallback callback, void* userdata) {
class UpdateScreenTest : public WizardInProcessBrowserTest {
public:
UpdateScreenTest() : WizardInProcessBrowserTest("update"),
- mock_session_manager_client_(NULL),
mock_update_library_(NULL),
mock_network_library_(NULL) {}
protected:
virtual void SetUpInProcessBrowserTestFixture() {
- DBusThreadManager::Initialize();
+ MockDBusThreadManager* mock_dbus_thread_manager =
+ new MockDBusThreadManager;
+ DBusThreadManager::InitializeForTesting(mock_dbus_thread_manager);
WizardInProcessBrowserTest::SetUpInProcessBrowserTestFixture();
cros_mock_->InitStatusAreaMocks();
cros_mock_->SetStatusAreaMocksExpectations();
ASSERT_TRUE(CrosLibrary::Get()->EnsureLoaded());
- mock_session_manager_client_ = new MockSessionManagerClient();
- DBusThreadManager::Get()->set_session_manager_client_for_testing(
- mock_session_manager_client_);
- EXPECT_CALL(*mock_session_manager_client_, EmitLoginPromptReady())
+ MockSessionManagerClient* mock_session_manager_client
+ = mock_dbus_thread_manager->mock_session_manager_client();
+ EXPECT_CALL(*mock_session_manager_client, EmitLoginPromptReady())
.Times(1);
mock_update_library_ = new MockUpdateLibrary();
@@ -90,14 +90,11 @@ class UpdateScreenTest : public WizardInProcessBrowserTest {
DBusThreadManager::Shutdown();
}
- MockSessionManagerClient* mock_session_manager_client_;
MockUpdateLibrary* mock_update_library_;
MockNetworkLibrary* mock_network_library_;
scoped_ptr<MockScreenObserver> mock_screen_observer_;
UpdateScreen* update_screen_;
- // DBusThreadManager needs a message loop.
- MessageLoopForUI message_loop_;
private:
DISALLOW_COPY_AND_ASSIGN(UpdateScreenTest);
« no previous file with comments | « chrome/browser/chromeos/login/signed_settings_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698