Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2832)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/metrics_log_manager.cc

Issue 8418034: Make string_util::WriteInto() DCHECK() that the supplied |length_with_null| > 1, meaning that the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/string_util.h ('K') | « chrome/browser/ui/views/omnibox/omnibox_view_win.cc ('k') | chrome/common/time_format.cc » ('j') | net/disk_cache/entry_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/metrics_log_manager.cc
===================================================================
--- chrome/common/metrics_log_manager.cc (revision 107404)
+++ chrome/common/metrics_log_manager.cc (working copy)
@@ -105,9 +105,10 @@
void MetricsLogManager::CompressStagedLog() {
int text_size = staged_log_->GetEncodedLogSize();
std::string staged_log_text;
- // Leave room for the NULL terminator.
- staged_log_->GetEncodedLog(WriteInto(&staged_log_text, text_size + 1),
- text_size);
+ if (text_size > 0) {
+ staged_log_->GetEncodedLog(WriteInto(&staged_log_text, text_size + 1),
+ text_size);
+ }
bool success = Bzip2Compress(staged_log_text, &compressed_staged_log_text_);
if (success) {
« base/string_util.h ('K') | « chrome/browser/ui/views/omnibox/omnibox_view_win.cc ('k') | chrome/common/time_format.cc » ('j') | net/disk_cache/entry_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698