sandbox/tests/common/controller.cc - Issue 8418034: Make string_util::WriteInto() DCHECK() that the supplied |length_with_null| > 1, meaning that the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/tests/common/controller.cc

Issue 8418034: Make string_util::WriteInto() DCHECK() that the supplied |length_with_null| > 1, meaning that the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/tests/common/controller.cc

===================================================================

--- sandbox/tests/common/controller.cc (revision 111826)

+++ sandbox/tests/common/controller.cc (working copy)

@@ -6,6 +6,7 @@

#include <string>

+#include "base/sys_string_conversions.h"

#include "base/win/windows_version.h"

#include "sandbox/src/sandbox_factory.h"

#include "sandbox/src/sandbox_utils.h"

@@ -261,7 +262,7 @@

&module))

return SBOX_TEST_FAILED_TO_EXECUTE_COMMAND;

- std::string command_name = WideToMultiByte(argv[3]);

+ std::string command_name = base::SysWideToMultiByte(argv[3], CP_UTF8);

CommandFunction command = reinterpret_cast<CommandFunction>(

::GetProcAddress(module, command_name.c_str()));

if (!command)

« no previous file with comments | « sandbox/src/sandbox_utils.cc ('k') | ui/base/clipboard/clipboard_win.cc » ('j') | no next file with comments »