chrome/browser/mac/install_from_dmg.mm - Issue 8418034: Make string_util::WriteInto() DCHECK() that the supplied |length_with_null| > 1, meaning that the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/mac/install_from_dmg.mm

Issue 8418034: Make string_util::WriteInto() DCHECK() that the supplied |length_with_null| > 1, meaning that the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/mac/install_from_dmg.mm

===================================================================

--- chrome/browser/mac/install_from_dmg.mm (revision 111826)

+++ chrome/browser/mac/install_from_dmg.mm (working copy)

@@ -141,6 +141,10 @@

CFDataRef image_path_data = static_cast<CFDataRef>(

image_path_cftyperef.get());

CFIndex length = CFDataGetLength(image_path_data);

+ if (length <= 0) {

+ LOG(ERROR) << "image_path_data is unexpectedly empty";

+ return true;

+ }

char* image_path_c = WriteInto(image_path, length + 1);

CFDataGetBytes(image_path_data,

CFRangeMake(0, length),

« no previous file with comments | « chrome/browser/browser_focus_uitest.cc ('k') | chrome/browser/shell_integration_win.cc » ('j') | no next file with comments »