Make string_util::WriteInto() DCHECK() that the supplied |length_with_null| > 1, meaning that the...

chrome_frame/utils.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/utils.h"
 
 #include <atlsafe.h>
 #include <atlsecurity.h>
 #include <htiframe.h>
 #include <mshtml.h>
@@ skipping 1310 matching lines @@
 
   if (flags)
     s += base::StringPrintf("+UnDoc[%#x]", flags);
   return s;
 #undef ADD_BSCF_FLAG
 }
 
 // Reads data from a stream into a string.
 HRESULT ReadStream(IStream* stream, size_t size, std::string* data) {
   DCHECK(stream);
+  DCHECK_GT(size, 0u);
   DCHECK(data);
 
   DWORD read = 0;
   HRESULT hr = stream->Read(WriteInto(data, size + 1), size, &read);
   DCHECK(hr == S_OK || hr == S_FALSE || hr == E_PENDING);
   if (read) {
     data->erase(read);
     DCHECK_EQ(read, data->length());
   } else {
     data->clear();
@@ skipping 292 matching lines @@
     ret = InternetSetOption(NULL, connection_options[option_index],
                             &connections, connection_value_size);
     if (!ret) {
       return false;
     }
   }
   wininet_connection_count_updated = true;
   return true;
 }