Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: chrome/browser/sync/test/integration/migration_errors_test.cc

Issue 8418030: [Sync] Mark MigratePrefsAndBoolkmarkThenModifyBookmark as flaky (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(akalin): Rename this file to migration_test.cc. 5 // TODO(akalin): Rename this file to migration_test.cc.
6 6
7 #include "chrome/browser/prefs/scoped_user_pref_update.h" 7 #include "chrome/browser/prefs/scoped_user_pref_update.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/sync/profile_sync_service_harness.h" 9 #include "chrome/browser/sync/profile_sync_service_harness.h"
10 #include "chrome/browser/sync/test/integration/bookmarks_helper.h" 10 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 // migration on one datatype, then modifies some other datatype. 342 // migration on one datatype, then modifies some other datatype.
343 // Flaky. crbug.com/100382. 343 // Flaky. crbug.com/100382.
344 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, 344 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest,
345 FLAKY_MigratePrefsThenModifyBookmark) { 345 FLAKY_MigratePrefsThenModifyBookmark) {
346 RunTwoClientMigrationTest(MakeList(syncable::PREFERENCES), 346 RunTwoClientMigrationTest(MakeList(syncable::PREFERENCES),
347 MODIFY_BOOKMARK); 347 MODIFY_BOOKMARK);
348 } 348 }
349 349
350 // Triggers a server migration on two datatypes, then makes a local 350 // Triggers a server migration on two datatypes, then makes a local
351 // modification to one of them. 351 // modification to one of them.
352 // Flaky. crbug.com/100382.
352 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, 353 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest,
353 MigratePrefsAndBookmarksThenModifyBookmark) { 354 FLAKY_MigratePrefsAndBookmarksThenModifyBookmark) {
354 RunTwoClientMigrationTest( 355 RunTwoClientMigrationTest(
355 MakeList(syncable::PREFERENCES, syncable::BOOKMARKS), 356 MakeList(syncable::PREFERENCES, syncable::BOOKMARKS),
356 MODIFY_BOOKMARK); 357 MODIFY_BOOKMARK);
357 } 358 }
358 359
359 // Migrate every datatype in sequence; the catch being that the server 360 // Migrate every datatype in sequence; the catch being that the server
360 // will only tell the client about the migrations one at a time. 361 // will only tell the client about the migrations one at a time.
361 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigrationHellWithoutNigori) { 362 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigrationHellWithoutNigori) {
362 ASSERT_TRUE(SetupClients()); 363 ASSERT_TRUE(SetupClients());
363 MigrationList migration_list = GetPreferredDataTypesList(); 364 MigrationList migration_list = GetPreferredDataTypesList();
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 447
447 // Phase 5: Verify that preferences can still be synchronized. 448 // Phase 5: Verify that preferences can still be synchronized.
448 VerifyPrefSync(); 449 VerifyPrefSync();
449 450
450 // Phase 6: Verify that sessions are registered and enabled. 451 // Phase 6: Verify that sessions are registered and enabled.
451 ASSERT_TRUE(GetClient(0)->IsTypeRunning(syncable::SESSIONS)); 452 ASSERT_TRUE(GetClient(0)->IsTypeRunning(syncable::SESSIONS));
452 ASSERT_TRUE(GetClient(0)->IsTypePreferred(syncable::SESSIONS)); 453 ASSERT_TRUE(GetClient(0)->IsTypePreferred(syncable::SESSIONS));
453 } 454 }
454 455
455 } // namespace 456 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698