Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: views/widget/native_widget_aura.cc

Issue 8418028: Destroy tooltip manager if the native window is destroyed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | views/widget/tooltip_manager_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/widget/native_widget_aura.cc
diff --git a/views/widget/native_widget_aura.cc b/views/widget/native_widget_aura.cc
index 11fcb076f8cf1dc2c295e175dc165dfca9341707..df6a2f964c585a16613cc32ca9b7a4b77a05c511 100644
--- a/views/widget/native_widget_aura.cc
+++ b/views/widget/native_widget_aura.cc
@@ -535,6 +535,10 @@ void NativeWidgetAura::OnPaint(gfx::Canvas* canvas) {
void NativeWidgetAura::OnWindowDestroying() {
delegate_->OnNativeWidgetDestroying();
+
+ // If the aura::Window is destryoed, we can no longer show tooltips.
sky 2011/10/28 18:26:33 'destryoed' -> destroyed
varunjain 2011/10/28 18:35:16 Done.
+ if (tooltip_manager_.get())
sky 2011/10/28 18:26:33 Not need to check this, just do reset.
varunjain 2011/10/28 18:35:16 Done.
+ tooltip_manager_.reset();
}
void NativeWidgetAura::OnWindowDestroyed() {
« no previous file with comments | « no previous file | views/widget/tooltip_manager_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698